Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Peter Maydell
On 28 March 2012 14:46, Andreas Färber wrote: > Am 28.03.2012 15:40, schrieb Peter Maydell: >> On 26 March 2012 18:28, Andreas Färber wrote: >> >>> +static void arm_cpu_reset(CPUState *c) >>> +{ >>> +    ARMCPU *cpu = ARM_CPU(c); >>> +    ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); >>> + >>> +  

Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Peter Maydell
On 26 March 2012 18:28, Andreas Färber wrote: > +static void arm_cpu_reset(CPUState *c) > +{ > +    ARMCPU *cpu = ARM_CPU(c); > +    ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); > + > +    class->parent_reset(c); > + > +    /* TODO Drop this in favor of cpu_arm_reset() calling cpu_reset() > +    

Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Andreas Färber
Am 28.03.2012 16:00, schrieb Max Filippov: > +static void arm_cpu_reset(CPUState *c) > +{ > +ARMCPU *cpu = ARM_CPU(c); > +ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); > + > +class->parent_reset(c); I thought we were avoiding 'class' in favour of 'klass'

Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Max Filippov
+static void arm_cpu_reset(CPUState *c) +{ +    ARMCPU *cpu = ARM_CPU(c); +    ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); + +    class->parent_reset(c); >>> >>> I thought we were avoiding 'class' in favour of 'klass'? >> >> I have suggested it once and I can only say

Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Andreas Färber
Am 28.03.2012 15:46, schrieb Max Filippov: >>> +static void arm_cpu_reset(CPUState *c) >>> +{ >>> +ARMCPU *cpu = ARM_CPU(c); >>> +ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); >>> + >>> +class->parent_reset(c); >> >> I thought we were avoiding 'class' in favour of 'klass'? > > I have su

Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Andreas Färber
Am 28.03.2012 15:40, schrieb Peter Maydell: > On 26 March 2012 18:28, Andreas Färber wrote: > >> +static void arm_cpu_reset(CPUState *c) >> +{ >> +ARMCPU *cpu = ARM_CPU(c); >> +ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); >> + >> +class->parent_reset(c); > > I thought we were avoidin

Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Max Filippov
>> +static void arm_cpu_reset(CPUState *c) >> +{ >> +    ARMCPU *cpu = ARM_CPU(c); >> +    ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); >> + >> +    class->parent_reset(c); > > I thought we were avoiding 'class' in favour of 'klass'? I have suggested it once and I can only say it again, please, ca

Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Peter Maydell
On 26 March 2012 18:28, Andreas Färber wrote: > +static void arm_cpu_reset(CPUState *c) > +{ > +    ARMCPU *cpu = ARM_CPU(c); > +    ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); > + > +    class->parent_reset(c); I thought we were avoiding 'class' in favour of 'klass'? > +static const TypeInfo

[Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-26 Thread Andreas Färber
Introduce only one non-abstract type TYPE_ARM_CPU and do not touch cp15 registers to not interfere with Peter's ongoing remodelling. Embed CPUARMState as first (additional) field of ARMCPU. Let reset call cpu_state_reset() for now. Signed-off-by: Andreas Färber --- Makefile.target |1 +