Re: [Qemu-devel] [PATCH v6 09/11] Dump: add qmp command "query-dump"

2016-02-15 Thread Peter Xu
On Tue, Feb 16, 2016 at 02:40:59PM +0800, Fam Zheng wrote: > On Wed, 12/09 10:42, Peter Xu wrote: > > -s->status = (local_err ? DUMP_STATUS_FAILED : DUMP_STATUS_COMPLETED); > > -error_propagate(errp, local_err); > > This means the error is released by caller, ... > > > +/* make sure s

Re: [Qemu-devel] [PATCH v6 09/11] Dump: add qmp command "query-dump"

2016-02-15 Thread Fam Zheng
On Wed, 12/09 10:42, Peter Xu wrote: > -s->status = (local_err ? DUMP_STATUS_FAILED : DUMP_STATUS_COMPLETED); > -error_propagate(errp, local_err); This means the error is released by caller, ... > +/* make sure status is written after written_size updates */ > +smp_wmb(); > +a

[Qemu-devel] [PATCH v6 09/11] Dump: add qmp command "query-dump"

2015-12-08 Thread Peter Xu
When dump-guest-memory is requested with detach flag, after its return, user could query its status using "query-dump" command (with no argument). The result contains: - status: current dump status - completed: bytes written in the latest dump - total: bytes to write in the latest dump >From comp