On Wed, 12/09 10:42, Peter Xu wrote: > - s->status = (local_err ? DUMP_STATUS_FAILED : DUMP_STATUS_COMPLETED); > - error_propagate(errp, local_err);
This means the error is released by caller, ... > + /* make sure status is written after written_size updates */ > + smp_wmb(); > + atomic_set(&s->status, > + (local_err ? DUMP_STATUS_FAILED : DUMP_STATUS_COMPLETED)); but it is removed now. Is local_err leaked now? Fam