Re: [Qemu-devel] [PATCH v6 08/12] vhost-user: add vhost_user_input_get_config()

On Wed, Mar 13, 2019 at 03:27:27PM +0100, Marc-André Lureau wrote: > Hi > > On Wed, Mar 13, 2019 at 3:16 PM Michael S. Tsirkin wrote: > > > > On Tue, Mar 12, 2019 at 09:19:01PM +0100, Marc-André Lureau wrote: > > > Hi > > > > > > On Tue, Mar 12, 2019 at 4:49 PM Michael S. Tsirkin > > > wrote: >

Re: [Qemu-devel] [PATCH v6 08/12] vhost-user: add vhost_user_input_get_config()

Hi On Wed, Mar 13, 2019 at 3:16 PM Michael S. Tsirkin wrote: > > On Tue, Mar 12, 2019 at 09:19:01PM +0100, Marc-André Lureau wrote: > > Hi > > > > On Tue, Mar 12, 2019 at 4:49 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Mar 08, 2019 at 03:04:50PM +0100, Marc-André Lureau wrote: > > > > Ask

Re: [Qemu-devel] [PATCH v6 08/12] vhost-user: add vhost_user_input_get_config()

On Tue, Mar 12, 2019 at 09:19:01PM +0100, Marc-André Lureau wrote: > Hi > > On Tue, Mar 12, 2019 at 4:49 PM Michael S. Tsirkin wrote: > > > > On Fri, Mar 08, 2019 at 03:04:50PM +0100, Marc-André Lureau wrote: > > > Ask vhost user input backend the list of virtio_input_config. > > > > > > Signed-o

Re: [Qemu-devel] [PATCH v6 08/12] vhost-user: add vhost_user_input_get_config()

Hi On Wed, Mar 13, 2019 at 7:26 AM Gerd Hoffmann wrote: > > > > And why host endianness? Everything else is little endian ... > > > > Hmm, I am not sure we correctly handle endianness in > > virtio_input_get_config(). virtio_input_add_config() do not use LE. > > Gerd, have you checked cross-endia

Re: [Qemu-devel] [PATCH v6 08/12] vhost-user: add vhost_user_input_get_config()

> > And why host endianness? Everything else is little endian ... > > Hmm, I am not sure we correctly handle endianness in > virtio_input_get_config(). virtio_input_add_config() do not use LE. > Gerd, have you checked cross-endian scenarios? Sure. BE ppc tcg guest on LE x86 host works fine. All

Re: [Qemu-devel] [PATCH v6 08/12] vhost-user: add vhost_user_input_get_config()

Hi On Tue, Mar 12, 2019 at 4:49 PM Michael S. Tsirkin wrote: > > On Fri, Mar 08, 2019 at 03:04:50PM +0100, Marc-André Lureau wrote: > > Ask vhost user input backend the list of virtio_input_config. > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Gerd Hoffmann > > I was pushing this an

Re: [Qemu-devel] [PATCH v6 08/12] vhost-user: add vhost_user_input_get_config()

On Fri, Mar 08, 2019 at 03:04:50PM +0100, Marc-André Lureau wrote: > Ask vhost user input backend the list of virtio_input_config. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Gerd Hoffmann I was pushing this and I am puzzled now. > --- > contrib/libvhost-user/libvhost-user.h | 1 + >

[Qemu-devel] [PATCH v6 08/12] vhost-user: add vhost_user_input_get_config()

Ask vhost user input backend the list of virtio_input_config. Signed-off-by: Marc-André Lureau Reviewed-by: Gerd Hoffmann --- contrib/libvhost-user/libvhost-user.h | 1 + include/hw/virtio/vhost-backend.h | 4 ++ hw/virtio/vhost-user.c| 60 +++ docs