Hi On Wed, Mar 13, 2019 at 7:26 AM Gerd Hoffmann <kra...@redhat.com> wrote: > > > > And why host endianness? Everything else is little endian ... > > > > Hmm, I am not sure we correctly handle endianness in > > virtio_input_get_config(). virtio_input_add_config() do not use LE. > > Gerd, have you checked cross-endian scenarios? > > Sure. BE ppc tcg guest on LE x86 host works fine. > > All 16 and 32 bit fields in config space and protocol > messages are defined to be little endian. It's a pure > virtio-1.0 device after all ... > > Note that all the fields virtio_input_get_config() and > virtio_input_add_config() are looking at are 8 bit. >
Right, thanks for clarifying. So we can simply drop "in host endianness" from VHOST_USER_INPUT_GET_CONFIG documentation. -- Marc-André Lureau
