Re: [Qemu-devel] [PATCH v6 02/11] fix some coding style problems

2016-06-01 Thread Cao jin
On 06/01/2016 04:09 PM, Markus Armbruster wrote: Cao jin writes: It has: 1. More newlines make the code block well separated. 2. Add more comments for msi_init. 3. Fix a indentation in vmxnet3.c. 4. ioh3420 & xio3130_downstream: put PCI Express capability init function together, make it

Re: [Qemu-devel] [PATCH v6 02/11] fix some coding style problems

2016-06-01 Thread Markus Armbruster
Cao jin writes: > It has: > 1. More newlines make the code block well separated. > 2. Add more comments for msi_init. > 3. Fix a indentation in vmxnet3.c. > 4. ioh3420 & xio3130_downstream: put PCI Express capability init function >together, make it more readable. > > cc: Dmitry Fleytman > c

[Qemu-devel] [PATCH v6 02/11] fix some coding style problems

2016-05-23 Thread Cao jin
It has: 1. More newlines make the code block well separated. 2. Add more comments for msi_init. 3. Fix a indentation in vmxnet3.c. 4. ioh3420 & xio3130_downstream: put PCI Express capability init function together, make it more readable. cc: Dmitry Fleytman cc: Jason Wang cc: Michael S. Tsirk