Re: [Qemu-devel] [PATCH v6 01/14] qapi: qapi for audio backends

2019-03-12 Thread Gerd Hoffmann
Hi, > >> +# @buffer-length: the buffer length in microseconds > > > > The name buffer-length suggests bytes rather than microseconds. That's > > why I suggested @buffer-capacity. Matter of taste, up to you and Gerd. > > @period-length has the same issue. For me @buffer-capacity and > @perio

Re: [Qemu-devel] [PATCH v6 01/14] qapi: qapi for audio backends

2019-03-09 Thread Zoltán Kővágó
On 2019-03-09 10:27, Markus Armbruster wrote: > "Kővágó, Zoltán" writes: > >> This patch adds structures into qapi to replace the existing >> configuration structures used by audio backends currently. This qapi >> will be the base of the -audiodev command line parameter (that replaces >> the old

Re: [Qemu-devel] [PATCH v6 01/14] qapi: qapi for audio backends

2019-03-09 Thread Markus Armbruster
"Kővágó, Zoltán" writes: > This patch adds structures into qapi to replace the existing > configuration structures used by audio backends currently. This qapi > will be the base of the -audiodev command line parameter (that replaces > the old environment variables based config). > > This is not a

[Qemu-devel] [PATCH v6 01/14] qapi: qapi for audio backends

2019-03-08 Thread Kővágó, Zoltán
This patch adds structures into qapi to replace the existing configuration structures used by audio backends currently. This qapi will be the base of the -audiodev command line parameter (that replaces the old environment variables based config). This is not a 1:1 translation of the old options, I