Hi, > >> +# @buffer-length: the buffer length in microseconds > > > > The name buffer-length suggests bytes rather than microseconds. That's > > why I suggested @buffer-capacity. Matter of taste, up to you and Gerd. > > @period-length has the same issue. For me @buffer-capacity and > @period-capacity feels a bit weird. I'm not 100% familiar with qapi > conventions, but for me 'size' is what's usually in bytes, and 'length' > can be something else (number of characters in a string, length of a > sound file, ...).
Agree here. "size" is linked to "bytes" in my head too, thinking of the "sizeof()" operator or DEFINE_PROP_SIZE() for example. Whereas "length" can be bytes (strlen) but can be other units too (wcslen). Pull request sent. thanks, Gerd
