Re: [Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save_live

2012-01-04 Thread Orit Wasserman
On 01/04/2012 02:14 PM, Stefan Hajnoczi wrote: > On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman wrote: >> +/* XOR encoding */ >> +xor_buf = (uint8_t *) g_malloc0(TARGET_PAGE_SIZE); > > Is this an old version of the code? I remember pointing out all the > useless zeroing in a previous rev

Re: [Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save_live

2012-01-04 Thread Stefan Hajnoczi
On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman wrote: > +    /* XOR encoding */ > +    xor_buf = (uint8_t *) g_malloc0(TARGET_PAGE_SIZE); Is this an old version of the code? I remember pointing out all the useless zeroing in a previous revision. If the next line is going to memcpy or overwrite

[Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save_live

2012-01-03 Thread Orit Wasserman
Add migration state to store XBRLE params (enablement and cache size). In the outgoing check to see if the page is cached and send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is set decompress the page (by using load_xbrle functi

[Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save_live

2012-01-03 Thread Orit Wasserman
Add migration state to store XBRLE params (enablement and cache size). In the outgoing check to see if the page is cached and send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is set decompress the page (by using load_xbrle functi