On 01/04/2012 02:14 PM, Stefan Hajnoczi wrote: > On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman <owass...@redhat.com> wrote: >> + /* XOR encoding */ >> + xor_buf = (uint8_t *) g_malloc0(TARGET_PAGE_SIZE); > > Is this an old version of the code? I remember pointing out all the > useless zeroing in a previous revision. If the next line is going to > memcpy or overwrite the entire buffer, please don't zero it first - > especially when the buffer isn't just a small struct.
I will fix it > > Stefan