Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report()

2013-07-04 Thread Stefan Hajnoczi
On Thu, Jul 04, 2013 at 02:57:13AM +, Seiji Aguchi wrote: > > > > -Original Message- > > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > > Sent: Wednesday, July 03, 2013 5:14 AM > > To: Seiji Aguchi > > Cc: qemu-devel@nongnu.org; aligu...@us.ibm.com; berra...@redhat.com; > > kw..

Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report()

2013-07-03 Thread Seiji Aguchi
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Wednesday, July 03, 2013 5:14 AM > To: Seiji Aguchi > Cc: qemu-devel@nongnu.org; aligu...@us.ibm.com; berra...@redhat.com; > kw...@redhat.com; mtosa...@redhat.com; > arm...@redhat.com; Tomoki Sekiyama; pbonz

Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report()

2013-07-03 Thread Seiji Aguchi
> Patches need to make sense today, please do not add extra code with > potential future use in mind: > > 1. Other developers must be able to read and modify the current codebase >on its own. They do not know what potential future changes you were >thinking about. > > 2. You may never en

Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report()

2013-07-03 Thread Stefan Hajnoczi
On Tue, Jul 02, 2013 at 02:09:24PM +, Seiji Aguchi wrote: > > > > > +DEF("msg", HAS_ARG, QEMU_OPTION_msg, > > > +"-msg [timestamp=on|off]\n" > > > +" change the format of messages\n" > > > +" timestamp=on|off enables leading timestamps (default:on)\n", > > > +QEMU_ARCH_ALL)

Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report()

2013-07-03 Thread Stefan Hajnoczi
On Tue, Jul 02, 2013 at 02:09:24PM +, Seiji Aguchi wrote: > > > diff --git a/util/qemu-time.c b/util/qemu-time.c > > > new file mode 100644 > > > index 000..3862788 > > > --- /dev/null > > > +++ b/util/qemu-time.c > > > @@ -0,0 +1,26 @@ > > > +/* > > > + * Time handling > > > + * > > > + *

Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report()

2013-07-02 Thread Seiji Aguchi
> > +DEF("msg", HAS_ARG, QEMU_OPTION_msg, > > +"-msg [timestamp=on|off]\n" > > +" change the format of messages\n" > > +" timestamp=on|off enables leading timestamps (default:on)\n", > > +QEMU_ARCH_ALL) > > +STEXI > > +@item -msg timestamp=on|off > > +@findex -msg > > +prepend a

Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report()

2013-07-02 Thread Stefan Hajnoczi
On Mon, Jul 01, 2013 at 02:54:07PM -0400, Seiji Aguchi wrote: > diff --git a/qemu-options.hx b/qemu-options.hx > index ca6fdf6..a6dac1a 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -3102,3 +3102,15 @@ HXCOMM This is the last statement. Insert new options > before this line! > STEXI

Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report()

2013-07-01 Thread Laszlo Ersek
On 07/01/13 20:54, Seiji Aguchi wrote: > [Issue] > When we offer a customer support service and a problem happens > in a customer's system, we try to understand the problem by > comparing what the customer reports with message logs of the > customer's system. > > In this case, we often need to kno

[Qemu-devel] [PATCH v5] Add timestamp to error_report()

2013-07-01 Thread Seiji Aguchi
[Issue] When we offer a customer support service and a problem happens in a customer's system, we try to understand the problem by comparing what the customer reports with message logs of the customer's system. In this case, we often need to know when the problem happens. But, currently, there is