On Tue, Jul 02, 2013 at 02:09:24PM +0000, Seiji Aguchi wrote:
>
>
> > > +DEF("msg", HAS_ARG, QEMU_OPTION_msg,
> > > + "-msg [timestamp=on|off]\n"
> > > + " change the format of messages\n"
> > > + " timestamp=on|off enables leading timestamps (default:on)\n",
> > > + QEMU_ARCH_ALL)
> > > +STEXI
> > > +@item -msg timestamp=on|off
> > > +@findex -msg
> > > +prepend a timestamp to each log message.
> > > +(disabled by default)
> > > +ETEXI
> >
> > I am confused. If the user specifies -msg then enable_timestamp_msg is
> > on by default. If the user does not specify -msg then
> > enable_timestmap_msg is off. Did I get that right?
>
> Yes.
>
> >
> > This means that the default behavior of QEMU does not change but you can
> > add -msg to enable timestamps.
> >
> > I'm happy with this but find the documentation confusing.
>
> I can remove "(disabled by default)" if needed.
Perhaps the simplest solution is timestamp=off by default. Then there
can be no confusion and users must do -msg timestamp=on to enable
timestamps.
If you really want to keep -msg as a shortcut for -msg timestamp=on,
then please document explicitly that:
1. Without -msg timestamps are off.
1. With -msg timestamps are on.
2. -msg timestamp=off can be used to turn timestamps off again.
Stefan
