Re: [Qemu-devel] [PATCH v4 4/8] spapr: Reorganize CPU dt generation code

2015-06-15 Thread David Gibson
On Fri, Jun 05, 2015 at 05:55:20PM +1000, Alexey Kardashevskiy wrote: > On 06/05/2015 05:06 PM, Bharata B Rao wrote: > >On Fri, Jun 05, 2015 at 04:09:48PM +1000, Alexey Kardashevskiy wrote: > >>> > >>>-ret = fdt_setprop(fdt, offset, "ibm,pft-size", > >>>- pft_size_p

Re: [Qemu-devel] [PATCH v4 4/8] spapr: Reorganize CPU dt generation code

2015-06-05 Thread Alexey Kardashevskiy
On 06/05/2015 05:06 PM, Bharata B Rao wrote: On Fri, Jun 05, 2015 at 04:09:48PM +1000, Alexey Kardashevskiy wrote: -ret = fdt_setprop(fdt, offset, "ibm,pft-size", - pft_size_prop, sizeof(pft_size_prop)); You broke formatting here, above 8 lines should not be i

Re: [Qemu-devel] [PATCH v4 4/8] spapr: Reorganize CPU dt generation code

2015-06-05 Thread Bharata B Rao
On Fri, Jun 05, 2015 at 04:09:48PM +1000, Alexey Kardashevskiy wrote: > > > >-ret = fdt_setprop(fdt, offset, "ibm,pft-size", > >- pft_size_prop, sizeof(pft_size_prop)); > > You broke formatting here, above 8 lines should not be in the patch. You mean above 80 char

Re: [Qemu-devel] [PATCH v4 4/8] spapr: Reorganize CPU dt generation code

2015-06-04 Thread Alexey Kardashevskiy
On 06/05/2015 02:25 PM, Bharata B Rao wrote: Reorganize CPU device tree generation code so that it be reused from hotplug path. CPU dt entries are now generated from spapr_finalize_fdt() instead of spapr_create_fdt_skel(). Note: This is how the split-up looks like now: Boot path - spapr

[Qemu-devel] [PATCH v4 4/8] spapr: Reorganize CPU dt generation code

2015-06-04 Thread Bharata B Rao
Reorganize CPU device tree generation code so that it be reused from hotplug path. CPU dt entries are now generated from spapr_finalize_fdt() instead of spapr_create_fdt_skel(). Note: This is how the split-up looks like now: Boot path - spapr_finalize_fdt spapr_populate_cpus_dt_node sp