Re: [Qemu-devel] [PATCH v4 2/4] util/fifo: Generalise for common integer widths

2014-05-14 Thread Peter Crosthwaite
On Tue, May 6, 2014 at 11:41 AM, Peter Crosthwaite wrote: > On Tue, Apr 29, 2014 at 2:57 AM, Peter Maydell > wrote: >> On 15 April 2014 04:18, Peter Crosthwaite >> wrote: >>> Add support for 16, 32 and 64 bit width FIFOs. The push and pop >>> functions are replicated to accept all four differe

Re: [Qemu-devel] [PATCH v4 2/4] util/fifo: Generalise for common integer widths

2014-05-05 Thread Peter Crosthwaite
On Tue, Apr 29, 2014 at 2:57 AM, Peter Maydell wrote: > On 15 April 2014 04:18, Peter Crosthwaite > wrote: >> Add support for 16, 32 and 64 bit width FIFOs. The push and pop >> functions are replicated to accept all four different integer types. >> The element width of the FIFO is set at creatio

Re: [Qemu-devel] [PATCH v4 2/4] util/fifo: Generalise for common integer widths

2014-04-28 Thread Peter Maydell
On 15 April 2014 04:18, Peter Crosthwaite wrote: > Add support for 16, 32 and 64 bit width FIFOs. The push and pop > functions are replicated to accept all four different integer types. > The element width of the FIFO is set at creation time. > > The backing storage for all element types is still

Re: [Qemu-devel] [PATCH v4 2/4] util/fifo: Generalise for common integer widths

2014-04-16 Thread Don Slutz
On 04/15/14 13:26, Beniamino Galvani wrote: On Mon, Apr 14, 2014 at 08:18:56PM -0700, Peter Crosthwaite wrote: Add support for 16, 32 and 64 bit width FIFOs. The push and pop functions are replicated to accept all four different integer types. The element width of the FIFO is set at creation tim

Re: [Qemu-devel] [PATCH v4 2/4] util/fifo: Generalise for common integer widths

2014-04-15 Thread Beniamino Galvani
On Mon, Apr 14, 2014 at 08:18:56PM -0700, Peter Crosthwaite wrote: > Add support for 16, 32 and 64 bit width FIFOs. The push and pop > functions are replicated to accept all four different integer types. > The element width of the FIFO is set at creation time. > > The backing storage for all eleme

[Qemu-devel] [PATCH v4 2/4] util/fifo: Generalise for common integer widths

2014-04-14 Thread Peter Crosthwaite
Add support for 16, 32 and 64 bit width FIFOs. The push and pop functions are replicated to accept all four different integer types. The element width of the FIFO is set at creation time. The backing storage for all element types is still uint8_t regardless of element width so some save-load logic