Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu

2015-09-15 Thread Richard Henderson
On 09/15/2015 12:28 PM, Peter Maydell wrote: > On 4 August 2015 at 20:16, Richard Henderson wrote: >> On 08/04/2015 12:08 PM, Alex Bennée wrote: > Would that make sense as a debug option or should we have a specific set > of TCG options to alter its behaviour? That's what I'

Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu

2015-09-15 Thread Peter Maydell
On 4 August 2015 at 20:16, Richard Henderson wrote: > On 08/04/2015 12:08 PM, Alex Bennée wrote: Would that make sense as a debug option or should we have a specific set of TCG options to alter its behaviour? >>> >>> >>> That's what I'm saying -- probably a separate debug option is bette

Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu

2015-08-04 Thread Richard Henderson
On 08/04/2015 10:22 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 08/04/2015 08:15 AM, Peter Maydell wrote: >>> On 4 August 2015 at 16:11, Alex Bennée wrote: Aurelien Jarno writes: > On 2015-08-03 10:14, Alex Bennée wrote: > In practice this is not true for linked T

Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu

2015-08-04 Thread Richard Henderson
On 08/04/2015 12:08 PM, Alex Bennée wrote: >>> Would that make sense as a debug option or should we have a specific set >>> of TCG options to alter its behaviour? >> >> >> That's what I'm saying -- probably a separate debug option is better. > > Sorry I meant should we add it to -d (as in -d nocha

Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu

2015-08-04 Thread Alex Bennée
Richard Henderson writes: > On 08/04/2015 10:22 AM, Alex Bennée wrote: >> >> Richard Henderson writes: >> >>> On 08/04/2015 08:15 AM, Peter Maydell wrote: On 4 August 2015 at 16:11, Alex Bennée wrote: > Aurelien Jarno writes: >> On 2015-08-03 10:14, Alex Bennée wrote: >> In

Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu

2015-08-04 Thread Alex Bennée
Richard Henderson writes: > On 08/04/2015 08:15 AM, Peter Maydell wrote: >> On 4 August 2015 at 16:11, Alex Bennée wrote: >>> Aurelien Jarno writes: On 2015-08-03 10:14, Alex Bennée wrote: In practice this is not true for linked TB. Should we also disable TB linking when this op

Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu

2015-08-04 Thread Richard Henderson
On 08/04/2015 08:15 AM, Peter Maydell wrote: > On 4 August 2015 at 16:11, Alex Bennée wrote: >> Aurelien Jarno writes: >>> On 2015-08-03 10:14, Alex Bennée wrote: >>> In practice this is not true for linked TB. Should we also disable TB >>> linking when this option is enabled? >> >> Good question

Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu

2015-08-04 Thread Peter Maydell
On 4 August 2015 at 16:11, Alex Bennée wrote: > Aurelien Jarno writes: >> On 2015-08-03 10:14, Alex Bennée wrote: >> In practice this is not true for linked TB. Should we also disable TB >> linking when this option is enabled? > > Good question. I suspect yes because if you've gone to level of wa

Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu

2015-08-04 Thread Alex Bennée
Aurelien Jarno writes: > On 2015-08-03 10:14, Alex Bennée wrote: >> This doesn't just dump CPU state on translation but on every block >> entrance. >> >> Signed-off-by: Alex Bennée >> Reviewed-by: Andreas Färber >> >> --- >> v4 >> - add r-b tag >> --- >> qemu-log.c | 2 +- >> 1 file chang

Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu

2015-08-04 Thread Aurelien Jarno
On 2015-08-03 10:14, Alex Bennée wrote: > This doesn't just dump CPU state on translation but on every block > entrance. > > Signed-off-by: Alex Bennée > Reviewed-by: Andreas Färber > > --- > v4 > - add r-b tag > --- > qemu-log.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

[Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu

2015-08-03 Thread Alex Bennée
This doesn't just dump CPU state on translation but on every block entrance. Signed-off-by: Alex Bennée Reviewed-by: Andreas Färber --- v4 - add r-b tag --- qemu-log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-log.c b/qemu-log.c index 13f3813..be8405e 100644 --