Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

2014-05-27 Thread Laszlo Ersek
On 05/27/14 15:00, Gabriel L. Somlo wrote: > On Mon, May 26, 2014 at 08:30:48AM +0200, Markus Armbruster wrote: >>> >>> So I was about to send a patch with acpi-test.c renamed to >>> bios-tables-test.c, but the patch is basically removing all of >>> acpi-test.c, and creating a new file bios-tables-

Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

2014-05-27 Thread Gabriel L. Somlo
On Mon, May 26, 2014 at 08:30:48AM +0200, Markus Armbruster wrote: > > > > So I was about to send a patch with acpi-test.c renamed to > > bios-tables-test.c, but the patch is basically removing all of > > acpi-test.c, and creating a new file bios-tables-test.c. > > Err, isn't that what a rename do

Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

2014-05-25 Thread Markus Armbruster
"Gabriel L. Somlo" writes: > On Fri, May 23, 2014 at 12:00:12PM +0300, Michael S. Tsirkin wrote: >> > 1. There's a fairly complex setup (create a boot disk, start the >> > guest, loop around waiting for the bios to finish booting, watch >> > when your disk-based boot loader runs, etc.) before sta

Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

2014-05-23 Thread Gabriel L. Somlo
On Fri, May 23, 2014 at 12:00:12PM +0300, Michael S. Tsirkin wrote: > > 1. There's a fairly complex setup (create a boot disk, start the > > guest, loop around waiting for the bios to finish booting, watch > > when your disk-based boot loader runs, etc.) before starting to > > examine the guest mem

Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

2014-05-23 Thread Michael S. Tsirkin
On Thu, May 22, 2014 at 09:27:11PM -0400, Gabriel L. Somlo wrote: > Michael, > > On Mon, May 19, 2014 at 10:44:48PM +0300, Michael S. Tsirkin wrote: > > One question: we don't seem to have unit-test for this > > interface in qemu, do we? > > I would like to see at least a basic test along the line

Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

2014-05-22 Thread Gabriel L. Somlo
Michael, On Mon, May 19, 2014 at 10:44:48PM +0300, Michael S. Tsirkin wrote: > One question: we don't seem to have unit-test for this > interface in qemu, do we? > I would like to see at least a basic test along the lines of > tests/acpi-test.c: run bios to load tables from QEMU, > then do some ba

Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

2014-05-20 Thread Gabriel L. Somlo
On Mon, May 19, 2014 at 10:44:48PM +0300, Michael S. Tsirkin wrote: > Thanks! > One question: we don't seem to have unit-test for this > interface in qemu, do we? > I would like to see at least a basic test along the lines of > tests/acpi-test.c: run bios to load tables from QEMU, > then do some ba

Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

2014-05-19 Thread Gerd Hoffmann
On Mo, 2014-05-19 at 19:09 +0300, Michael S. Tsirkin wrote: > On Mon, May 19, 2014 at 10:09:52AM -0400, Gabriel L. Somlo wrote: > > Changelog: > > OK I queued this, but not yet pushed (to collect acks). > Gerd if it should be your tree instead pls let me know. I was planning to do a pull for this

Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

2014-05-19 Thread Michael S. Tsirkin
On Mon, May 19, 2014 at 10:09:52AM -0400, Gabriel L. Somlo wrote: > Changelog: > > new in v4: > - slightly improved commit blurbs > > v3: > - endian-ness fix (1/3) now correctly handles cpuid version and features > - included documentation (qemu-options.hx) for type 0 uefi flag (2/3) > -

Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

2014-05-19 Thread Michael S. Tsirkin
On Mon, May 19, 2014 at 10:09:52AM -0400, Gabriel L. Somlo wrote: > Changelog: OK I queued this, but not yet pushed (to collect acks). Gerd if it should be your tree instead pls let me know. > new in v4: > - slightly improved commit blurbs > > v3: > - endian-ness fix (1/3) now correctly hand

[Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

2014-05-19 Thread Gabriel L. Somlo
Changelog: new in v4: - slightly improved commit blurbs v3: - endian-ness fix (1/3) now correctly handles cpuid version and features - included documentation (qemu-options.hx) for type 0 uefi flag (2/3) - fixed type 17 field sizes ("word" means 16 bits, not 32 :) :) v2: - fix endian-n