On Mon, May 26, 2014 at 08:30:48AM +0200, Markus Armbruster wrote: > > > > So I was about to send a patch with acpi-test.c renamed to > > bios-tables-test.c, but the patch is basically removing all of > > acpi-test.c, and creating a new file bios-tables-test.c. > > Err, isn't that what a rename does?
Being somewhere in the middle of the Git learning curve, to me a rename mostly means editing a string in a filesystem directory entry, without touching the actual content :) > > Do you have a better way to rename the file first, and then I can > > send a patch against it ? Or should we give up on renaming it > > altogether ? Or should I just bite the bullet and cut'n'paste your > > test harness into a new file specific to smbios ? > > > > It's not particularly important to me which way we go -- I want to do > > the right thing, whatever you decide that is :) > > Did you rename with git-mv? Did you diff with rename detection on? See > diff.renames in git-config(1). Aaaah, that's what I was missing! This makes for a much more "articulate" looking patch (which I'll be sending out shortly) :) Thanks a ton, --Gabriel
