Re: [Qemu-devel] [PATCH v3 21/26] tcg-aarch64: Introduce tcg_out_insn_3507

2014-04-11 Thread Claudio Fontana
Just to remember that there is an issue with this, as the previous reviewed-by tag by me might mislead: Nacked-by: Claudio Fontana On 03.04.2014 21:56, Richard Henderson wrote: > Cleaning up the implementation of REV and REV16 at the same time. > > Reviewed-by: Claudio Fontana > Signed-off-by

Re: [Qemu-devel] [PATCH v3 21/26] tcg-aarch64: Introduce tcg_out_insn_3507

2014-04-09 Thread Richard Henderson
On 04/09/2014 05:54 AM, Claudio Fontana wrote: > During testing I found this patch causes a regression for big endian targets > (sparc). > > Can you take a look? > I think it might be related to the extended form of the REV instruction > needing > an additional 0x400. See below. You're right.

Re: [Qemu-devel] [PATCH v3 21/26] tcg-aarch64: Introduce tcg_out_insn_3507

2014-04-09 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: > Cleaning up the implementation of REV and REV16 at the same time. > > Reviewed-by: Claudio Fontana > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 22 ++ > 1 file changed, 14 insertions(+), 8 deletions(-)

[Qemu-devel] [PATCH v3 21/26] tcg-aarch64: Introduce tcg_out_insn_3507

2014-04-03 Thread Richard Henderson
Cleaning up the implementation of REV and REV16 at the same time. Reviewed-by: Claudio Fontana Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-tar