Re: [Qemu-devel] [PATCH v3 17/46] ivshmem: improve debug messages

2015-09-23 Thread Marc-André Lureau
Hi On Wed, Sep 23, 2015 at 2:10 PM, Claudio Fontana wrote: >> Let's change it for IVSHMEM_DPRINTF("use msix, present: %d\n", >> msix_present(d)); ok? >> > > what about something like > > IVSHMEM_DPRINTF("%susing MSI-X\n", msix_present(d) ? "" : "not "); > > or just > > if (!msix_present(d) { >

Re: [Qemu-devel] [PATCH v3 17/46] ivshmem: improve debug messages

2015-09-23 Thread Claudio Fontana
On 23.09.2015 12:29, Marc-André Lureau wrote: > On Tue, Sep 22, 2015 at 4:23 PM, Claudio Fontana > wrote: >> This MSI-X use vs not use is a bit confusing to me. >> I see that the use of MSI is controlled mainly by IVSHMEM_MSI (Property >> "msi"), >> but then there are if (msix_present()) checks s

Re: [Qemu-devel] [PATCH v3 17/46] ivshmem: improve debug messages

2015-09-23 Thread Marc-André Lureau
On Tue, Sep 22, 2015 at 4:23 PM, Claudio Fontana wrote: > This MSI-X use vs not use is a bit confusing to me. > I see that the use of MSI is controlled mainly by IVSHMEM_MSI (Property > "msi"), > but then there are if (msix_present()) checks spread around. > > Could this printf be a bit more clea

Re: [Qemu-devel] [PATCH v3 17/46] ivshmem: improve debug messages

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Some misc improvements to ivshmem debug. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/hw/misc/ivshmem.c b

[Qemu-devel] [PATCH v3 17/46] ivshmem: improve debug messages

2015-09-15 Thread marcandre . lureau
From: Marc-André Lureau Some misc improvements to ivshmem debug. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index cda7dce..084bc89 100644 --- a/hw/misc/ivshmem.c +++