On 23.09.2015 12:29, Marc-André Lureau wrote:
> On Tue, Sep 22, 2015 at 4:23 PM, Claudio Fontana
> <claudio.font...@huawei.com> wrote:
>> This MSI-X use vs not use is a bit confusing to me.
>> I see that the use of MSI is controlled mainly by IVSHMEM_MSI (Property
>> "msi"),
>> but then there are if (msix_present()) checks spread around.
>>
>> Could this printf be a bit more clear, possibly adding other DPRINTFs as
>> necessary?
>>
>> Is your IVSHMEM_DPRINTF("use msix\n"); actually intended to mean ("using
>> MSIX\n")? But then why is the check for if (!msix_present(d)) only
>> afterwards?
>
>
> I don't remember precisely why it's there, only I probably wanted to
> trace the entering of function ivshmem_use_msix().
>
> Let's change it for IVSHMEM_DPRINTF("use msix, present: %d\n",
> msix_present(d)); ok?
>
what about something like
IVSHMEM_DPRINTF("%susing MSI-X\n", msix_present(d) ? "" : "not ");
or just
if (!msix_present(d) {
IVSHMEM_DPRINTF("not using MSI-X");
return;
}
IVSHMEM_DPRINTF("using MSI-X");
Ciao
CLaudio
