Re: [Qemu-devel] [PATCH v3 1/2] pvpanic: initialization cleanup

2013-06-20 Thread Stefano Stabellini
On Wed, 19 Jun 2013, Michael S. Tsirkin wrote: > -int pvpanic_init(ISABus *bus) > +void pvpanic_init(ISABus *bus) > { > -isa_create_simple(bus, TYPE_ISA_PVPANIC_DEVICE); > -return 0; > +ISADevice *dev; > +FWCfgState *fw_cfg = fw_cfg_find(); > +if (!fw_cfg) { > +return;

Re: [Qemu-devel] [PATCH v3 1/2] pvpanic: initialization cleanup

2013-06-20 Thread Laszlo Ersek
On 06/19/13 17:02, Michael S. Tsirkin wrote: > Avoid use of static variables: PC systems > initialize pvpanic device through pvpanic_init, > so we can simply create the fw_cfg file at that point. > This also makes it possible to skip device > creation completely if fw_cfg is not there, e.g. for xen

[Qemu-devel] [PATCH v3 1/2] pvpanic: initialization cleanup

2013-06-19 Thread Michael S. Tsirkin
Avoid use of static variables: PC systems initialize pvpanic device through pvpanic_init, so we can simply create the fw_cfg file at that point. This also makes it possible to skip device creation completely if fw_cfg is not there, e.g. for xen - so the ports it reserves are not discoverable by gue