On Wed, 19 Jun 2013, Michael S. Tsirkin wrote: > -int pvpanic_init(ISABus *bus) > +void pvpanic_init(ISABus *bus) > { > - isa_create_simple(bus, TYPE_ISA_PVPANIC_DEVICE); > - return 0; > + ISADevice *dev; > + FWCfgState *fw_cfg = fw_cfg_find(); > + if (!fw_cfg) { > + return; > + } > + dev = isa_create_simple (bus, TYPE_ISA_PVPANIC_DEVICE); > + pvpanic_fw_cfg(dev, fw_cfg); > }
looks OK to me