Re: [Qemu-devel] [PATCH v3 1/2] hw/loader: Support ramdisk with u-boot header

2013-07-19 Thread Sören Brinkmann
On Sat, Jul 20, 2013 at 12:20:48AM +0100, Peter Maydell wrote: > On 19 July 2013 18:53, Sören Brinkmann wrote: > > On Fri, Jul 19, 2013 at 06:46:57PM +0100, Peter Maydell wrote: > >> On 19 July 2013 18:39, Sören Brinkmann wrote: > >> > On Fri, Jul 19, 2013 at 01:04:20PM +0100, Peter Maydell wrote

Re: [Qemu-devel] [PATCH v3 1/2] hw/loader: Support ramdisk with u-boot header

2013-07-19 Thread Peter Maydell
On 19 July 2013 18:53, Sören Brinkmann wrote: > On Fri, Jul 19, 2013 at 06:46:57PM +0100, Peter Maydell wrote: >> On 19 July 2013 18:39, Sören Brinkmann wrote: >> > On Fri, Jul 19, 2013 at 01:04:20PM +0100, Peter Maydell wrote: >> >> On 8 July 2013 23:40, Soren Brinkmann wrote: >> >> > + >> >> >

Re: [Qemu-devel] [PATCH v3 1/2] hw/loader: Support ramdisk with u-boot header

2013-07-19 Thread Sören Brinkmann
On Fri, Jul 19, 2013 at 01:04:20PM +0100, Peter Maydell wrote: > On 8 July 2013 23:40, Soren Brinkmann wrote: > > + > > +if (ep) { > > +*ep = hdr->ih_ep; > > +} > > (Allowing ep to be NULL for IH_TYPE_KERNEL is new behaviour, > but it makes sense for consistency with t

Re: [Qemu-devel] [PATCH v3 1/2] hw/loader: Support ramdisk with u-boot header

2013-07-19 Thread Sören Brinkmann
On Fri, Jul 19, 2013 at 06:46:57PM +0100, Peter Maydell wrote: > On 19 July 2013 18:39, Sören Brinkmann wrote: > > On Fri, Jul 19, 2013 at 01:04:20PM +0100, Peter Maydell wrote: > >> On 8 July 2013 23:40, Soren Brinkmann wrote: > >> > + > >> > +if (ep) { > >> > +*ep = hdr->ih_

Re: [Qemu-devel] [PATCH v3 1/2] hw/loader: Support ramdisk with u-boot header

2013-07-19 Thread Peter Maydell
On 19 July 2013 18:39, Sören Brinkmann wrote: > On Fri, Jul 19, 2013 at 01:04:20PM +0100, Peter Maydell wrote: >> On 8 July 2013 23:40, Soren Brinkmann wrote: >> > + >> > +if (ep) { >> > +*ep = hdr->ih_ep; >> > +} >> >> (Allowing ep to be NULL for IH_TYPE_KERNEL is new

Re: [Qemu-devel] [PATCH v3 1/2] hw/loader: Support ramdisk with u-boot header

2013-07-19 Thread Peter Maydell
On 8 July 2013 23:40, Soren Brinkmann wrote: > + > +if (ep) { > +*ep = hdr->ih_ep; > +} (Allowing ep to be NULL for IH_TYPE_KERNEL is new behaviour, but it makes sense for consistency with the other pointer argument handling.) > + > +/* TODO: Check CPU type.

[Qemu-devel] [PATCH v3 1/2] hw/loader: Support ramdisk with u-boot header

2013-07-08 Thread Soren Brinkmann
Introduce 'load_ramdisk()' which can load "normal" ramdisks and ramdisks with a u-boot header. To enable this and leverage synergies 'load_uimage()' is refactored to accomodate this additional use case. Signed-off-by: Soren Brinkmann --- v3: - remove fallback code from load_ramdisk(). This way t