On 8 July 2013 23:40, Soren Brinkmann <soren.brinkm...@xilinx.com> wrote:
> +
> + if (ep) {
> + *ep = hdr->ih_ep;
> + }
(Allowing ep to be NULL for IH_TYPE_KERNEL is new behaviour,
but it makes sense for consistency with the other pointer
argument handling.)
> +
> + /* TODO: Check CPU type. */
> + if (is_linux) {
> + if (hdr->ih_os == IH_OS_LINUX) {
> + *is_linux = 1;
> + } else {
> + *is_linux = 0;
> + }
> + }
> +
> + break;
> + case IH_TYPE_RAMDISK:
> + address = *loadaddr;
This is inconsistent -- for IH_TYPE_KERNEL we accept
a NULL loadaddr, but for IH_TYPE_RAMDISK we don't.
-- PMM
