Re: [Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-07-01 Thread Bandan Das
Alex Williamson writes: ... >> */ >> if (vendor == PCI_VENDOR_ID_CHELSIO && (device & 0xff00) == 0x5800) { >> vdev->msix->pba_offset = 0x1000; >> } else { >> error_report("vfio: Hardware reports invalid configuration, " >> "

Re: [Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-07-01 Thread Alex Williamson
xt for this version. Thanks, Alex > -Original Message- > From: Bandan Das [mailto:b...@redhat.com] > Sent: Tuesday, June 30, 2015 6:48 PM > To: Gabriel Laupre > Cc: jb-gnumli...@wisemo.com; Casey Leedom; m...@redhat.com; > qemu-devel@nongnu.org; Anish Bhatt; Michael

Re: [Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-07-01 Thread Gabriel Laupre
e- From: Bandan Das [mailto:b...@redhat.com] Sent: Tuesday, June 30, 2015 6:48 PM To: Gabriel Laupre Cc: jb-gnumli...@wisemo.com; Casey Leedom; m...@redhat.com; qemu-devel@nongnu.org; Anish Bhatt; Michael Boksanyi; alex.william...@redhat.com; b...@makefile.in Subject: Re: [Qemu-devel] [PATCH v3]

Re: [Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-30 Thread Gabriel Laupre
Message- From: Bandan Das [mailto:b...@redhat.com] Sent: Tuesday, June 30, 2015 6:48 PM To: Gabriel Laupre Cc: jb-gnumli...@wisemo.com; Casey Leedom; m...@redhat.com; qemu-devel@nongnu.org; Anish Bhatt; Michael Boksanyi; alex.william...@redhat.com; b...@makefile.in Subject: Re: [Qemu-devel] [

Re: [Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-30 Thread Gabriel Laupre
Bhatt; Michael Boksanyi; alex.william...@redhat.com; b...@makefile.in Subject: Re: [Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for Chelsio T5 devices Gabriel Laupre writes: > @ Bandan ... >> > + + /* Chelsio T5 Virtual Function devices are encoded as 0x58xx >> >

Re: [Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-30 Thread Bandan Das
Gabriel Laupre writes: > @ Bandan ... >> > + + /* Chelsio T5 Virtual Function devices are encoded as 0x58xx >> > for T5 + * adapters. The T5 hardware returns an incorrect value of >> > 0x8000 for + * the VF PBA offset. The correct value is 0x1000, so >> > we hard code that + * here. */ + if (vend

Re: [Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-30 Thread Gabriel Laupre
@ Bandan ... > > + > > +/* Chelsio T5 Virtual Function devices are encoded as 0x58xx for T5 > > + * adapters. The T5 hardware returns an incorrect value of 0x8000 > > for > > + * the VF PBA offset. The correct value is 0x1000, so we hard code > > that > > + * here.

Re: [Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-30 Thread Casey Leedom
: Gabriel Laupre; qemu-devel@nongnu.org; jb-gnumli...@wisemo.com; Casey Leedom; m...@redhat.com; Anish Bhatt; Michael Boksanyi; b...@makefile.in Subject: Re: [Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for Chelsio T5 devices On Tue, 2015-06-30 at 17:58 -0400, Bandan Das wrote: > Gabr

Re: [Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-30 Thread Alex Williamson
On Tue, 2015-06-30 at 17:58 -0400, Bandan Das wrote: > Gabriel Laupre writes: > ... > > +/* Test the size of the pba variables and catch if they extend outside > > of > > + * the specified BAR. If it is the case, we have a broken > > configuration or > > + * we need to apply a hardwa

Re: [Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-30 Thread Bandan Das
Gabriel Laupre writes: ... > +/* Test the size of the pba variables and catch if they extend outside of > + * the specified BAR. If it is the case, we have a broken configuration > or > + * we need to apply a hardware specific quirk. */ > +if (vdev->msix->table_offset >= > +

Re: [Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-30 Thread Alex Williamson
On Tue, 2015-06-30 at 14:03 -0700, Gabriel Laupre wrote: > Fix pba_offset initialization value for Chelsio T5 Virtual Function > device. The T5 hardware has a bug in it where it reports a Pending Interrupt > Bit Array Offset of 0x8000 for its SR-IOV Virtual Functions instead > of the 0x1000 that th

[Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-30 Thread Gabriel Laupre
Fix pba_offset initialization value for Chelsio T5 Virtual Function device. The T5 hardware has a bug in it where it reports a Pending Interrupt Bit Array Offset of 0x8000 for its SR-IOV Virtual Functions instead of the 0x1000 that the hardware actually uses internally. As the hardware doesn't retu