Alex Williamson <alex.william...@redhat.com> writes:
...
>> */
>> if (vendor == PCI_VENDOR_ID_CHELSIO && (device & 0xff00) == 0x5800) {
>> vdev->msix->pba_offset = 0x1000;
>> } else {
>> error_report("vfio: Hardware reports invalid configuration, "
>> "MSIX data outside of specified BAR");
>> return -EINVAL;
>> }
>> }
>> ...
>>
>> As the hardware problem is only related with the pba_offset and the purpose
>> of the quirk is to correct the known hardware error. The table_offset has
>> never been seen as wrong. Therefore the msix_init() sanity check should take
>> care of a "rare" potential error as you mentioned.
>>
>> This time I'll wait for ACKs from your side before submitting a new version
>> :)
>
> I would s/data/PBA/ in the error_report text for this version. Thanks,
Looks good to me, Gabriel + what Alex mentioned above.
Thanks,
Bandan
