Re: [Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong

2014-11-11 Thread SeokYeon Hwang
SeokYeon Hwang > >> Cc: qemu-devel@nongnu.org; kongjian...@gmail.com; > >> paolo.bonz...@gmail.com; mre...@redhat.com > >> Subject: Re: [Qemu-devel] [PATCH v3] error: passing a negative value > >> to an os_errno is wrong > >> > >> SeokYeon Hwang

Re: [Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong

2014-11-11 Thread SeokYeon Hwang
> -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Tuesday, November 11, 2014 1:14 AM > To: SeokYeon Hwang; qemu-devel@nongnu.org > Cc: paolo.bonz...@gmail.com; arm...@redhat.com; mre...@redhat.com; > kongjian...@gmail.com > Subject: Re: [PATCH v3] error: passing a n

Re: [Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong

2014-11-10 Thread Eric Blake
On 11/09/2014 10:54 PM, SeokYeon Hwang wrote: > Added 'assert(os_errno > 0)' in 'error_set_errno()'. Commit message... > Fixed errno since it passes wrong value to 'error_set_errno()'. > > Signed-off-by: SeokYeon Hwang > --- > hw/pci/pcie.c | 2 +- > +++ b/util/error.c > @@ -62,6 +62,7 @@ void

Re: [Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong

2014-11-10 Thread Markus Armbruster
...@redhat.com >> Subject: Re: [Qemu-devel] [PATCH v3] error: passing a negative value to an >> os_errno is wrong >> >> SeokYeon Hwang writes: >> >> > Added 'assert(os_errno > 0)' in 'error_set_errno()'. >> > Fixed errno since i

Re: [Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong

2014-11-10 Thread SeokYeon Hwang
> -Original Message- > From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Monday, November 10, 2014 6:33 PM > To: SeokYeon Hwang > Cc: qemu-devel@nongnu.org; kongjian...@gmail.com; paolo.bonz...@gmail.com; > mre...@redhat.com > Subject: Re: [Qemu-devel] [PATCH

Re: [Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong

2014-11-10 Thread Markus Armbruster
SeokYeon Hwang writes: > Added 'assert(os_errno > 0)' in 'error_set_errno()'. > Fixed errno since it passes wrong value to 'error_set_errno()'. > > Signed-off-by: SeokYeon Hwang > --- > hw/pci/pcie.c | 2 +- > util/error.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong

2014-11-10 Thread Max Reitz
On 2014-11-10 at 06:54, SeokYeon Hwang wrote: Added 'assert(os_errno > 0)' in 'error_set_errno()'. Fixed errno since it passes wrong value to 'error_set_errno()'. Signed-off-by: SeokYeon Hwang --- hw/pci/pcie.c | 2 +- util/error.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) di

Re: [Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong

2014-11-09 Thread Amos Kong
On Mon, Nov 10, 2014 at 02:54:49PM +0900, SeokYeon Hwang wrote: > Added 'assert(os_errno > 0)' in 'error_set_errno()'. > Fixed errno since it passes wrong value to 'error_set_errno()'. > > Signed-off-by: SeokYeon Hwang Reviewed-by: Amos Kong > --- > hw/pci/pcie.c | 2 +- > util/error.c | 1 +

[Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong

2014-11-09 Thread SeokYeon Hwang
Added 'assert(os_errno > 0)' in 'error_set_errno()'. Fixed errno since it passes wrong value to 'error_set_errno()'. Signed-off-by: SeokYeon Hwang --- hw/pci/pcie.c | 2 +- util/error.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 5845