Re: [Qemu-devel] [PATCH v3] CODING_STYLE: Section about mixed declarations

2014-03-21 Thread Eduardo Habkost
On Fri, Mar 21, 2014 at 07:04:08PM +0100, Fabien Chouteau wrote: > On 03/17/2014 07:26 PM, Eduardo Habkost wrote: > > We had an unwritten rule about declarations having to be at beginning of > > blocks. Make it a written rule. > > > > Hello Eduardo, > > Is it possible to check this rule in scrip

Re: [Qemu-devel] [PATCH v3] CODING_STYLE: Section about mixed declarations

2014-03-21 Thread Fabien Chouteau
On 03/17/2014 07:26 PM, Eduardo Habkost wrote: > We had an unwritten rule about declarations having to be at beginning of > blocks. Make it a written rule. > Hello Eduardo, Is it possible to check this rule in script/checkpatch.pl? (or is it already?) Regards,

[Qemu-devel] [PATCH v3] CODING_STYLE: Section about mixed declarations

2014-03-17 Thread Eduardo Habkost
We had an unwritten rule about declarations having to be at beginning of blocks. Make it a written rule. Signed-off-by: Eduardo Habkost Reviewed-by: Stefan Weil Reviewed-by: Markus Armbruster --- Changes v3: * Wrap long lines Changes v2: * s/be at beginning/be at the beginning/ --- CODING_S

Re: [Qemu-devel] [PATCH v3] CODING_STYLE: Section about mixed declarations

2014-03-17 Thread Peter Maydell
On 17 March 2014 18:26, Eduardo Habkost wrote: > We had an unwritten rule about declarations having to be at beginning of > blocks. Make it a written rule. > > Signed-off-by: Eduardo Habkost > Reviewed-by: Stefan Weil > Reviewed-by: Markus Armbruster Reviewed-by: Peter Maydell -- PMM