We had an unwritten rule about declarations having to be at beginning of blocks. Make it a written rule.
Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> Reviewed-by: Stefan Weil <s...@weilnetz.de> Reviewed-by: Markus Armbruster <arm...@redhat.com> --- Changes v3: * Wrap long lines Changes v2: * s/be at beginning/be at the beginning/ --- CODING_STYLE | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/CODING_STYLE b/CODING_STYLE index dcbce28..4280945 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -84,3 +84,10 @@ and clarity it comes on a line by itself: Rationale: a consistent (except for functions...) bracing style reduces ambiguity and avoids needless churn when lines are added or removed. Furthermore, it is the QEMU coding style. + +5. Declarations + +Mixed declarations (interleaving statements and declarations within blocks) +are not allowed; declarations should be at the beginning of blocks. In other +words, the code should not generate warnings if using GCC's +-Wdeclaration-after-statement option. -- 1.8.5.3
