Re: [Qemu-devel] [PATCH v2 6/7] exec: Factor out section_covers_addr

2016-03-01 Thread Fam Zheng
On Tue, 03/01 10:42, Paolo Bonzini wrote: > > > On 01/03/2016 07:18, Fam Zheng wrote: > > +/* Memory topology clips a memory region to 2^64, size.hi >= 0 means > > the > > + * section must cover any addr. */ > > Small improvement: > > /* Memory topology clips a memory region to [0,

Re: [Qemu-devel] [PATCH v2 6/7] exec: Factor out section_covers_addr

2016-03-01 Thread Paolo Bonzini
On 01/03/2016 07:18, Fam Zheng wrote: > +/* Memory topology clips a memory region to 2^64, size.hi >= 0 means the > + * section must cover any addr. */ Small improvement: /* Memory topology clips a memory region to [0, 2^64); size.hi > 0 means * the section must cover the entir

Re: [Qemu-devel] [PATCH v2 6/7] exec: Factor out section_covers_addr

2016-02-29 Thread Peter Xu
On Tue, Mar 01, 2016 at 02:18:23PM +0800, Fam Zheng wrote: > This will be shared by the next patch. > > Also add a comment explaining the unobvious condition on "size.hi". > > Signed-off-by: Fam Zheng Reviewed-by: Peter Xu > --- > exec.c | 14 +++--- > 1 file changed, 11 insertions(+

[Qemu-devel] [PATCH v2 6/7] exec: Factor out section_covers_addr

2016-02-29 Thread Fam Zheng
This will be shared by the next patch. Also add a comment explaining the unobvious condition on "size.hi". Signed-off-by: Fam Zheng --- exec.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index ad8b826..b4e2eb5 100644 --- a/exec.c +++ b/exe