Re: [Qemu-devel] [PATCH v2 5/7] target/m68k: add moves

2018-01-16 Thread Richard Henderson
On 01/16/2018 09:48 AM, Laurent Vivier wrote: > Le 15/01/2018 à 19:37, Richard Henderson a écrit : >> On 01/12/2018 04:43 PM, Laurent Vivier wrote: > ... >>> -dc->user = (env->sr & SR_S) == 0; >>> +#if defined(CONFIG_SOFTMMU) >>> +dc->user = (env->sr & SR_S) == 0 ? M68K_USER_FROM_MSR : 0; >

Re: [Qemu-devel] [PATCH v2 5/7] target/m68k: add moves

2018-01-16 Thread Laurent Vivier
Le 15/01/2018 à 19:37, Richard Henderson a écrit : > On 01/12/2018 04:43 PM, Laurent Vivier wrote: ... >> -dc->user = (env->sr & SR_S) == 0; >> +#if defined(CONFIG_SOFTMMU) >> +dc->user = (env->sr & SR_S) == 0 ? M68K_USER_FROM_MSR : 0; >> +dc->user |= (env->sfc & 4) == 0 ? M68K_USER_FRO

Re: [Qemu-devel] [PATCH v2 5/7] target/m68k: add moves

2018-01-15 Thread Richard Henderson
On 01/12/2018 04:43 PM, Laurent Vivier wrote: > index 1aadc622db..efe2bf90ee 100644 > --- a/target/m68k/qregs.def > +++ b/target/m68k/qregs.def > @@ -1,5 +1,7 @@ > DEFO32(PC, pc) > DEFO32(SR, sr) > +DEFO32(DFC, dfc) > +DEFO32(SFC, sfc) These are unused. No need to define or initialize. > #if

[Qemu-devel] [PATCH v2 5/7] target/m68k: add moves

2018-01-12 Thread Laurent Vivier
and introduce SFC and DFC control registers. Signed-off-by: Laurent Vivier --- v2: copy bit 2 of SFC and DFC to tb->flags to inline memory access in moves decoder. target/m68k/cpu.h | 10 -- target/m68k/helper.c| 10 ++ target/m68k/monitor.c | 2 ++ target/m68k/op_helpe