On Fri, May 30, 2014 at 2:00 AM, Gabriel L. Somlo wrote:
> Hi Peter,
>
> Thanks for the QOM crash course !
>
> So I did s/TYPE_E1000/TYPE_E1000_BASE/ as suggested by Stefan, and
> also moved PCI_VENDOR_ID_INTEL back into e1000_class_init() and away
> from e1000_devices[] as you suggested. That's g
Hi Peter,
Thanks for the QOM crash course !
So I did s/TYPE_E1000/TYPE_E1000_BASE/ as suggested by Stefan, and
also moved PCI_VENDOR_ID_INTEL back into e1000_class_init() and away
from e1000_devices[] as you suggested. That's going to be part of
v3, as soon as we're done talking about QOM, see be
On Thu, May 22, 2014 at 4:27 AM, Gabriel L. Somlo wrote:
> Allow selection of different card models from the qemu
> command line, to better accomodate a wider range of guests.
>
> Signed-off-by: Romain Dolbeau
> Signed-off-by: Gabriel Somlo
> ---
> hw/net/e1000.c | 95
> +++
On Wed, May 21, 2014 at 02:27:43PM -0400, Gabriel L. Somlo wrote:
> -#define TYPE_E1000 "e1000"
> +#define TYPE_E1000 "e1000-base"
Please rename to TYPE_E1000_BASE.
It's confusing to call it TYPE_E1000 but then actually have a different
type use the "e1000" string.
Besides that, I'm happy.
Stef
Allow selection of different card models from the qemu
command line, to better accomodate a wider range of guests.
Signed-off-by: Romain Dolbeau
Signed-off-by: Gabriel Somlo
---
hw/net/e1000.c | 95 --
1 file changed, 79 insertions(+), 16
