On Wed, May 21, 2014 at 02:27:43PM -0400, Gabriel L. Somlo wrote:
> -#define TYPE_E1000 "e1000"
> +#define TYPE_E1000 "e1000-base"

Please rename to TYPE_E1000_BASE.

It's confusing to call it TYPE_E1000 but then actually have a different
type use the "e1000" string.

Besides that, I'm happy.

Stefan

Reply via email to