Re: [Qemu-devel] [PATCH v2 1/5] KVM: eventfd: Fix lock order inversion.

2014-03-18 Thread Paolo Bonzini
Il 17/03/2014 22:55, Christian Borntraeger ha scritto: > Signed-off-by: Cornelia Huck Do you still have the lockdep message somewhere? Looking at the patch and the description this makes sense. Even without irqfd for s390: Reviewed-by: Christian Borntraeger Paolo, maybe this patch can go in i

Re: [Qemu-devel] [PATCH v2 1/5] KVM: eventfd: Fix lock order inversion.

2014-03-18 Thread Cornelia Huck
On Mon, 17 Mar 2014 22:55:49 +0100 Christian Borntraeger wrote: > On 17/03/14 19:11, Cornelia Huck wrote: > > When registering a new irqfd, we call its ->poll method to collect any > > event that might have previously been pending so that we can trigger it. > > This is done under the kvm->irqfds.

Re: [Qemu-devel] [PATCH v2 1/5] KVM: eventfd: Fix lock order inversion.

2014-03-17 Thread Christian Borntraeger
On 17/03/14 19:11, Cornelia Huck wrote: > When registering a new irqfd, we call its ->poll method to collect any > event that might have previously been pending so that we can trigger it. > This is done under the kvm->irqfds.lock, which means the eventfd's ctx > lock is taken under it. > > However

[Qemu-devel] [PATCH v2 1/5] KVM: eventfd: Fix lock order inversion.

2014-03-17 Thread Cornelia Huck
When registering a new irqfd, we call its ->poll method to collect any event that might have previously been pending so that we can trigger it. This is done under the kvm->irqfds.lock, which means the eventfd's ctx lock is taken under it. However, if we get a POLLHUP in irqfd_wakeup, we will be ca