On Mon, 17 Mar 2014 22:55:49 +0100 Christian Borntraeger <borntrae...@de.ibm.com> wrote:
> On 17/03/14 19:11, Cornelia Huck wrote: > > When registering a new irqfd, we call its ->poll method to collect any > > event that might have previously been pending so that we can trigger it. > > This is done under the kvm->irqfds.lock, which means the eventfd's ctx > > lock is taken under it. > > > > However, if we get a POLLHUP in irqfd_wakeup, we will be called with the > > ctx lock held before getting the irqfds.lock to deactivate the irqfd, > > causing lockdep to complain. > > > > Calling the ->poll method does not really need the irqfds.lock, so let's > > just move it after we've given up the irqfds.lock in kvm_irqfd_assign(). > > > > Signed-off-by: Cornelia Huck <cornelia.h...@de.ibm.com> > Do you still have the lockdep message somewhere? Unfortunately not, and it does not seem to be readily triggerable. > Looking at the patch and the description this makes sense. Even without > irqfd for s390: > Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> > > Paolo, maybe this patch can go in independently from s390? > > Christian
