Re: [Qemu-devel] [PATCH v2 1/2] Deprecate QMP `cpu-add`

2018-10-08 Thread Markus Armbruster
Kashyap Chamarthy writes: > On Mon, Oct 01, 2018 at 11:28:17AM +0200, Thomas Huth wrote: >> On 2018-09-25 18:02, Kashyap Chamarthy wrote: > > [...] > >> > +++ b/qapi/misc.json >> > @@ -1104,7 +1104,11 @@ >> > ## >> > # @cpu-add: >> > # >> > -# Adds CPU with specified ID >> > +# Adds CPU with s

Re: [Qemu-devel] [PATCH v2 1/2] Deprecate QMP `cpu-add`

2018-10-01 Thread Kashyap Chamarthy
On Mon, Oct 01, 2018 at 11:28:17AM +0200, Thomas Huth wrote: > On 2018-09-25 18:02, Kashyap Chamarthy wrote: [...] > > +++ b/qapi/misc.json > > @@ -1104,7 +1104,11 @@ > > ## > > # @cpu-add: > > # > > -# Adds CPU with specified ID > > +# Adds CPU with specified ID. > > +# > > +# Notes: This com

Re: [Qemu-devel] [PATCH v2 1/2] Deprecate QMP `cpu-add`

2018-10-01 Thread Thomas Huth
On 2018-09-25 18:02, Kashyap Chamarthy wrote: > The intended functionality of QMP `cpu-add` is replaced with > `device_add` (and `query-hotpluggable-cpus`). So let's deprecate > `cpu-add`. > > A complete example of vCPU hotplug with the recommended way (using > `device_add`) is provided as part o

[Qemu-devel] [PATCH v2 1/2] Deprecate QMP `cpu-add`

2018-09-25 Thread Kashyap Chamarthy
The intended functionality of QMP `cpu-add` is replaced with `device_add` (and `query-hotpluggable-cpus`). So let's deprecate `cpu-add`. A complete example of vCPU hotplug with the recommended way (using `device_add`) is provided as part of a seperate docs patch. Suggested-by: Eduardo Habkost -