Kashyap Chamarthy <kcham...@redhat.com> writes: > On Mon, Oct 01, 2018 at 11:28:17AM +0200, Thomas Huth wrote: >> On 2018-09-25 18:02, Kashyap Chamarthy wrote: > > [...] > >> > +++ b/qapi/misc.json >> > @@ -1104,7 +1104,11 @@ >> > ## >> > # @cpu-add: >> > # >> > -# Adds CPU with specified ID >> > +# Adds CPU with specified ID. >> > +# >> > +# Notes: This command is deprecated. The `device_add` command should be >> >> s/Notes/Note/ ? > > Yeah, first I wrote the singular. But went with plural as I saw it as > it was the 'majority' pattern: > > $> git grep "Note:" qapi/misc.json | wc -l > 13 > $> git grep "Notes:" qapi/misc.json | wc -l > 18
Not exactly overwhelming majority :) > Maybe people use the plural, "Notes", as they can add multiple entries. For what it's worth, our doc generator recognizes both. [...]
