Re: [Qemu-devel] [PATCH v2 09/22] virtio: Remove unneeded includes

2018-08-10 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Fri, Aug 10, 2018 at 12:01:44PM +0200, Juan Quintela wrote: >> "Michael S. Tsirkin" wrote: >> > On Fri, Aug 10, 2018 at 09:34:32AM +0200, Juan Quintela wrote: >> >> "Michael S. Tsirkin" wrote: >> >> > On Thu, Aug 09, 2018 at 08:03:03PM +0100, Dr. David Alan Gilbe

Re: [Qemu-devel] [PATCH v2 09/22] virtio: Remove unneeded includes

2018-08-10 Thread Michael S. Tsirkin
On Fri, Aug 10, 2018 at 12:01:44PM +0200, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Fri, Aug 10, 2018 at 09:34:32AM +0200, Juan Quintela wrote: > >> "Michael S. Tsirkin" wrote: > >> > On Thu, Aug 09, 2018 at 08:03:03PM +0100, Dr. David Alan Gilbert wrote: > >> >> * Juan Quintela (

Re: [Qemu-devel] [PATCH v2 09/22] virtio: Remove unneeded includes

2018-08-10 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Fri, Aug 10, 2018 at 09:34:32AM +0200, Juan Quintela wrote: >> "Michael S. Tsirkin" wrote: >> > On Thu, Aug 09, 2018 at 08:03:03PM +0100, Dr. David Alan Gilbert wrote: >> >> * Juan Quintela (quint...@redhat.com) wrote: >> >> > They are all already included in virt

Re: [Qemu-devel] [PATCH v2 09/22] virtio: Remove unneeded includes

2018-08-10 Thread Michael S. Tsirkin
On Fri, Aug 10, 2018 at 09:34:32AM +0200, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Thu, Aug 09, 2018 at 08:03:03PM +0100, Dr. David Alan Gilbert wrote: > >> * Juan Quintela (quint...@redhat.com) wrote: > >> > They are all already included in virtio_pci.h. > > > > All I see in virt

Re: [Qemu-devel] [PATCH v2 09/22] virtio: Remove unneeded includes

2018-08-10 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Thu, Aug 09, 2018 at 08:03:03PM +0100, Dr. David Alan Gilbert wrote: >> * Juan Quintela (quint...@redhat.com) wrote: >> > They are all already included in virtio_pci.h. > > All I see in virtio_pci.h is: > > #include "standard-headers/linux/types.h" > > Weird. > > B

Re: [Qemu-devel] [PATCH v2 09/22] virtio: Remove unneeded includes

2018-08-09 Thread Michael S. Tsirkin
On Thu, Aug 09, 2018 at 08:03:03PM +0100, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: > > They are all already included in virtio_pci.h. All I see in virtio_pci.h is: #include "standard-headers/linux/types.h" Weird. BTW what's the point of this patch? Generally

Re: [Qemu-devel] [PATCH v2 09/22] virtio: Remove unneeded includes

2018-08-09 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > They are all already included in virtio_pci.h. > > Signed-off-by: Juan Quintela cc'ing in mst for virtio goodness. > --- > hw/virtio/virtio-pci.c | 15 +-- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/hw/virtio

Re: [Qemu-devel] [PATCH v2 09/22] virtio: Remove unneeded includes

2018-08-08 Thread Thomas Huth
On 08/08/2018 01:48 PM, Juan Quintela wrote: > They are all already included in virtio_pci.h. > > Signed-off-by: Juan Quintela > --- > hw/virtio/virtio-pci.c | 15 +-- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c

[Qemu-devel] [PATCH v2 09/22] virtio: Remove unneeded includes

2018-08-08 Thread Juan Quintela
They are all already included in virtio_pci.h. Signed-off-by: Juan Quintela --- hw/virtio/virtio-pci.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 3a01fe90f0..cb2ddd3f41 100644 --- a/hw/virtio/virtio-pc