On Thu, Aug 09, 2018 at 08:03:03PM +0100, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: > > They are all already included in virtio_pci.h.
All I see in virtio_pci.h is: #include "standard-headers/linux/types.h" Weird. BTW what's the point of this patch? Generally it's best not to depend on headers including each other, it makes refactoring harder. > > > > Signed-off-by: Juan Quintela <quint...@redhat.com> > > > cc'ing in mst for virtio goodness. > > > > --- > > hw/virtio/virtio-pci.c | 15 +-------------- > > 1 file changed, 1 insertion(+), 14 deletions(-) > > > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > > index 3a01fe90f0..cb2ddd3f41 100644 > > --- a/hw/virtio/virtio-pci.c > > +++ b/hw/virtio/virtio-pci.c > > @@ -18,24 +18,11 @@ > > #include "qemu/osdep.h" > > > > #include "standard-headers/linux/virtio_pci.h" > > -#include "hw/virtio/virtio.h" > > -#include "hw/virtio/virtio-blk.h" > > -#include "hw/virtio/virtio-net.h" > > -#include "hw/virtio/virtio-serial.h" > > -#include "hw/virtio/virtio-scsi.h" > > -#include "hw/virtio/virtio-balloon.h" > > -#include "hw/virtio/virtio-input.h" > > -#include "hw/pci/pci.h" > > +#include "virtio-pci.h" > > #include "qapi/error.h" > > -#include "qemu/error-report.h" > > -#include "hw/pci/msi.h" > > #include "hw/pci/msix.h" > > -#include "hw/loader.h" > > #include "sysemu/kvm.h" > > -#include "virtio-pci.h" > > #include "qemu/range.h" > > -#include "hw/virtio/virtio-bus.h" > > -#include "qapi/visitor.h" > > > > #define VIRTIO_PCI_REGION_SIZE(dev) > > VIRTIO_PCI_CONFIG_OFF(msix_present(dev)) > > > > -- > > 2.17.1 > > > -- > Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
