Re: [Qemu-devel] [PATCH v2 00/11] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-12 Thread Markus Armbruster
Kevin Wolf writes: > monitor.c mixes a lot of different things in a single file: The core > monitor infrastructure, HMP infrastrcture, QMP infrastructure, and the > implementation of several HMP and QMP commands. Almost worse, struct > Monitor mixes state for HMP, for QMP, and state actually shar

Re: [Qemu-devel] [PATCH v2 00/11] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190611134043.9524-1-kw...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190611134043.9524-1-kw...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/11] monitor: Split monitor.c in

Re: [Qemu-devel] [PATCH v2 00/11] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190611134043.9524-1-kw...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 00/11] monitor: Split monitor.c in core/HMP/QMP/misc Type: series Message-id

[Qemu-devel] [PATCH v2 00/11] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-11 Thread Kevin Wolf
monitor.c mixes a lot of different things in a single file: The core monitor infrastructure, HMP infrastrcture, QMP infrastructure, and the implementation of several HMP and QMP commands. Almost worse, struct Monitor mixes state for HMP, for QMP, and state actually shared between all monitors. moni