Re: [Qemu-devel] [PATCH v2] qom: fix inherited interfaces

2013-12-24 Thread Andreas Färber
Am 24.12.2013 12:17, schrieb Paolo Bonzini: > Il 24/12/2013 01:18, Andreas Färber ha scritto: >> Thanks, I have squashed it, but I would appreciate if someone more >> familiar with interfaces could take a quick look at my commit message >> before I send a PULL tomorrow. Should I drop Reported-by du

Re: [Qemu-devel] [PATCH v2] qom: fix inherited interfaces

2013-12-24 Thread Paolo Bonzini
Il 24/12/2013 01:18, Andreas Färber ha scritto: > Thanks, I have squashed it, but I would appreciate if someone more > familiar with interfaces could take a quick look at my commit message > before I send a PULL tomorrow. Should I drop Reported-by during squash? > > https://github.com/afaerber/qem

Re: [Qemu-devel] [PATCH v2] qom: fix inherited interfaces

2013-12-23 Thread Andreas Färber
Am 20.12.2013 22:54, schrieb Paolo Bonzini: > The interface type rework had two bugs with interfaces that are inherited > from a superclass. First of all, the implementation type name was wrong > (for example it was subclass::superclass::interface rather than > just subclass::interface). Second,

[Qemu-devel] [PATCH v2] qom: fix inherited interfaces

2013-12-20 Thread Paolo Bonzini
The interface type rework had two bugs with interfaces that are inherited from a superclass. First of all, the implementation type name was wrong (for example it was subclass::superclass::interface rather than just subclass::interface). Second, interfaces not registering their type anymore means