Am 20.12.2013 22:54, schrieb Paolo Bonzini: > The interface type rework had two bugs with interfaces that are inherited > from a superclass. First of all, the implementation type name was wrong > (for example it was subclass::superclass::interface rather than > just subclass::interface). Second, interfaces not registering their > type anymore means that accessing superclass::interface by type name > will fail. > > This can be fixed by pre-initializing ti->parent_type of subclass::interface > to superclass::interface. > > Reported-by: Igor Mammedov <imamm...@redhat.com> > Tested-by: Igor Mammedov <imamm...@redhat.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > Andreas, perhaps this can be squashed with > 'qom: do not register interface "types" in the type table'.
Thanks, I have squashed it, but I would appreciate if someone more familiar with interfaces could take a quick look at my commit message before I send a PULL tomorrow. Should I drop Reported-by during squash? https://github.com/afaerber/qemu-cpu/commits/qom-next Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
