Re: [Qemu-devel] [PATCH v2] hmp: gpa2hva and gpa2hpa hostaddr command

2017-03-27 Thread Dr. David Alan Gilbert
* Paolo Bonzini (bonz...@gnu.org) wrote: > > > On 20/03/2017 18:16, Paolo Bonzini wrote: > > > > > > On 20/03/2017 18:01, Markus Armbruster wrote: > >> Peter Maydell writes: > >> > >>> On 20 March 2017 at 16:29, Markus Armbruster wrote: > Peter Maydell writes: > > I have some commen

Re: [Qemu-devel] [PATCH v2] hmp: gpa2hva and gpa2hpa hostaddr command

2017-03-27 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > These commands are useful when testing machine-check passthrough. > gpa2hva is useful to inject a MADV_HWPOISON madvise from gdb, while > gpa2hpa is useful to inject an error with the mce-inject kernel > module. > > Signed-off-by: Paolo Bonzini Revi

Re: [Qemu-devel] [PATCH v2] hmp: gpa2hva and gpa2hpa hostaddr command

2017-03-27 Thread Dr. David Alan Gilbert
* Paolo Bonzini (bonz...@gnu.org) wrote: > > > On 20/03/2017 18:16, Paolo Bonzini wrote: > > > > > > On 20/03/2017 18:01, Markus Armbruster wrote: > >> Peter Maydell writes: > >> > >>> On 20 March 2017 at 16:29, Markus Armbruster wrote: > Peter Maydell writes: > > I have some commen

Re: [Qemu-devel] [PATCH v2] hmp: gpa2hva and gpa2hpa hostaddr command

2017-03-24 Thread Paolo Bonzini
On 20/03/2017 18:16, Paolo Bonzini wrote: > > > On 20/03/2017 18:01, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 20 March 2017 at 16:29, Markus Armbruster wrote: Peter Maydell writes: > I have some comments which feel kind of nit-picky, but since this > is a publ

Re: [Qemu-devel] [PATCH v2] hmp: gpa2hva and gpa2hpa hostaddr command

2017-03-20 Thread Paolo Bonzini
On 20/03/2017 18:01, Markus Armbruster wrote: > Peter Maydell writes: > >> On 20 March 2017 at 16:29, Markus Armbruster wrote: >>> Peter Maydell writes: I have some comments which feel kind of nit-picky, but since this is a public-facing HMP API I think they need attention since we

Re: [Qemu-devel] [PATCH v2] hmp: gpa2hva and gpa2hpa hostaddr command

2017-03-20 Thread Markus Armbruster
Peter Maydell writes: > On 20 March 2017 at 16:29, Markus Armbruster wrote: >> Peter Maydell writes: >>> I have some comments which feel kind of nit-picky, but since this >>> is a public-facing HMP API I think they need attention since we only >>> get one chance to get it right. >> >> HMP is no

Re: [Qemu-devel] [PATCH v2] hmp: gpa2hva and gpa2hpa hostaddr command

2017-03-20 Thread Paolo Bonzini
On 20/03/2017 17:32, Peter Maydell wrote: > On 20 March 2017 at 16:29, Markus Armbruster wrote: >> Peter Maydell writes: >>> I have some comments which feel kind of nit-picky, but since this >>> is a public-facing HMP API I think they need attention since we only >>> get one chance to get it ri

Re: [Qemu-devel] [PATCH v2] hmp: gpa2hva and gpa2hpa hostaddr command

2017-03-20 Thread Peter Maydell
On 20 March 2017 at 16:29, Markus Armbruster wrote: > Peter Maydell writes: >> I have some comments which feel kind of nit-picky, but since this >> is a public-facing HMP API I think they need attention since we only >> get one chance to get it right. > > HMP is not a stable interface. If we get

Re: [Qemu-devel] [PATCH v2] hmp: gpa2hva and gpa2hpa hostaddr command

2017-03-20 Thread Markus Armbruster
Peter Maydell writes: > On 20 March 2017 at 14:45, Paolo Bonzini wrote: >> These commands are useful when testing machine-check passthrough. >> gpa2hva is useful to inject a MADV_HWPOISON madvise from gdb, while >> gpa2hpa is useful to inject an error with the mce-inject kernel >> module. >> >>

Re: [Qemu-devel] [PATCH v2] hmp: gpa2hva and gpa2hpa hostaddr command

2017-03-20 Thread Paolo Bonzini
On 20/03/2017 15:56, Peter Maydell wrote: > On 20 March 2017 at 14:45, Paolo Bonzini wrote: >> These commands are useful when testing machine-check passthrough. >> gpa2hva is useful to inject a MADV_HWPOISON madvise from gdb, while >> gpa2hpa is useful to inject an error with the mce-inject kern

Re: [Qemu-devel] [PATCH v2] hmp: gpa2hva and gpa2hpa hostaddr command

2017-03-20 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > These commands are useful when testing machine-check passthrough. > gpa2hva is useful to inject a MADV_HWPOISON madvise from gdb, while > gpa2hpa is useful to inject an error with the mce-inject kernel > module. > > Signed-off-by: Paolo Bonzini Revi

Re: [Qemu-devel] [PATCH v2] hmp: gpa2hva and gpa2hpa hostaddr command

2017-03-20 Thread Peter Maydell
On 20 March 2017 at 14:45, Paolo Bonzini wrote: > These commands are useful when testing machine-check passthrough. > gpa2hva is useful to inject a MADV_HWPOISON madvise from gdb, while > gpa2hpa is useful to inject an error with the mce-inject kernel > module. > > Signed-off-by: Paolo Bonzini >

[Qemu-devel] [PATCH v2] hmp: gpa2hva and gpa2hpa hostaddr command

2017-03-20 Thread Paolo Bonzini
These commands are useful when testing machine-check passthrough. gpa2hva is useful to inject a MADV_HWPOISON madvise from gdb, while gpa2hpa is useful to inject an error with the mce-inject kernel module. Signed-off-by: Paolo Bonzini --- hmp-commands.hx | 32 ++ monitor.c