Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion

2012-08-22 Thread Andreas Färber
Am 15.12.2011 19:09, schrieb Anthony Liguori: > On 11/30/2011 09:26 AM, Andreas Färber wrote: >> Commit 95c318f5e1f88d7e5bcc6deac17330fd4806a2d3 (Fix segfault in mmio >> subpage handling code.) prevented a segfault by making all subpage >> registrations over an existing memory page perform an unass

Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion

2011-12-15 Thread Anthony Liguori
On 11/30/2011 09:26 AM, Andreas Färber wrote: Commit 95c318f5e1f88d7e5bcc6deac17330fd4806a2d3 (Fix segfault in mmio subpage handling code.) prevented a segfault by making all subpage registrations over an existing memory page perform an unassigned access. Symptoms were writes not taking effect an

Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion

2011-12-11 Thread Avi Kivity
On 11/30/2011 05:26 PM, Andreas Färber wrote: > Commit 95c318f5e1f88d7e5bcc6deac17330fd4806a2d3 (Fix segfault in mmio > subpage handling code.) prevented a segfault by making all subpage > registrations over an existing memory page perform an unassigned access. > Symptoms were writes not taking eff

Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion

2011-12-09 Thread Andreas Färber
Am 01.12.2011 10:29, schrieb Avi Kivity: > On 11/30/2011 05:26 PM, Andreas Färber wrote: >> Commit 95c318f5e1f88d7e5bcc6deac17330fd4806a2d3 (Fix segfault in mmio >> subpage handling code.) prevented a segfault by making all subpage >> registrations over an existing memory page perform an unassigned

Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion

2011-12-01 Thread Avi Kivity
On 12/01/2011 07:18 PM, Andreas Färber wrote: > Am 01.12.2011 11:06, schrieb Gleb Natapov: > > On Thu, Dec 01, 2011 at 11:54:33AM +0200, Avi Kivity wrote: > >> On 12/01/2011 11:47 AM, Gleb Natapov wrote: > >>> On Thu, Dec 01, 2011 at 11:41:52AM +0200, Avi Kivity wrote: > On 12/01/2011 11:37 AM

Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion

2011-12-01 Thread Andreas Färber
Am 01.12.2011 11:06, schrieb Gleb Natapov: > On Thu, Dec 01, 2011 at 11:54:33AM +0200, Avi Kivity wrote: >> On 12/01/2011 11:47 AM, Gleb Natapov wrote: >>> On Thu, Dec 01, 2011 at 11:41:52AM +0200, Avi Kivity wrote: On 12/01/2011 11:37 AM, Gleb Natapov wrote: >> >> Looks reasonable. S

Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion

2011-12-01 Thread Gleb Natapov
On Thu, Dec 01, 2011 at 11:54:33AM +0200, Avi Kivity wrote: > On 12/01/2011 11:47 AM, Gleb Natapov wrote: > > On Thu, Dec 01, 2011 at 11:41:52AM +0200, Avi Kivity wrote: > > > On 12/01/2011 11:37 AM, Gleb Natapov wrote: > > > > > > > > > > Looks reasonable. Should go into 1.1. Should we backport

Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion

2011-12-01 Thread Avi Kivity
On 12/01/2011 11:47 AM, Gleb Natapov wrote: > On Thu, Dec 01, 2011 at 11:41:52AM +0200, Avi Kivity wrote: > > On 12/01/2011 11:37 AM, Gleb Natapov wrote: > > > > > > > > Looks reasonable. Should go into 1.1. Should we backport it to > > > > 1.0.blah? From 95c318f's description, it doesn't happe

Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion

2011-12-01 Thread Gleb Natapov
On Thu, Dec 01, 2011 at 11:41:52AM +0200, Avi Kivity wrote: > On 12/01/2011 11:37 AM, Gleb Natapov wrote: > > > > > > Looks reasonable. Should go into 1.1. Should we backport it to > > > 1.0.blah? From 95c318f's description, it doesn't happen in normal > > > circumstances. > > > > > To reprodu

Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion

2011-12-01 Thread Avi Kivity
On 12/01/2011 11:37 AM, Gleb Natapov wrote: > > > > Looks reasonable. Should go into 1.1. Should we backport it to > > 1.0.blah? From 95c318f's description, it doesn't happen in normal > > circumstances. > > > To reproduce that I mappped subpage PCI bar over RAM IIRC. In qemu 1.0, you can no

Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion

2011-12-01 Thread Gleb Natapov
On Thu, Dec 01, 2011 at 11:29:48AM +0200, Avi Kivity wrote: > On 11/30/2011 05:26 PM, Andreas Färber wrote: > > Commit 95c318f5e1f88d7e5bcc6deac17330fd4806a2d3 (Fix segfault in mmio > > subpage handling code.) prevented a segfault by making all subpage > > registrations over an existing memory page

Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion

2011-12-01 Thread Avi Kivity
On 11/30/2011 05:26 PM, Andreas Färber wrote: > Commit 95c318f5e1f88d7e5bcc6deac17330fd4806a2d3 (Fix segfault in mmio > subpage handling code.) prevented a segfault by making all subpage > registrations over an existing memory page perform an unassigned access. > Symptoms were writes not taking eff

[Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion

2011-11-30 Thread Andreas Färber
Commit 95c318f5e1f88d7e5bcc6deac17330fd4806a2d3 (Fix segfault in mmio subpage handling code.) prevented a segfault by making all subpage registrations over an existing memory page perform an unassigned access. Symptoms were writes not taking effect and reads returning zero. Very small page sizes a