Am 01.12.2011 10:29, schrieb Avi Kivity: > On 11/30/2011 05:26 PM, Andreas Färber wrote: >> Commit 95c318f5e1f88d7e5bcc6deac17330fd4806a2d3 (Fix segfault in mmio >> subpage handling code.) prevented a segfault by making all subpage >> registrations over an existing memory page perform an unassigned access. >> Symptoms were writes not taking effect and reads returning zero. >> >> Very small page sizes are not currently supported either, >> so subpage memory areas cannot fully be avoided. >> >> Therefore change the previous fix to use a new IO_MEM_SUBPAGE_RAM >> instead of IO_MEM_UNASSIGNED. Suggested by Avi. >> >> > > Looks reasonable. Should go into 1.1.
A formal Reviewed-by or Acked-by may help. :) > Should we backport it to > 1.0.blah? From 95c318f's description, it doesn't happen in normal > circumstances. We feel it should be backported to both 1.0.x and 0.15.x, please. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
