Re: [Qemu-devel] [PATCH v2] block: mirror - use local_err to avoid NULL errp

2014-02-14 Thread Stefan Hajnoczi
On Thu, Feb 13, 2014 at 09:23:38AM -0500, Jeff Cody wrote: > When starting a block job, commit_active_start() relies on whether *errp > is set by mirror_start_job. This allows it to determine if the mirror > job start failed, so that it can clean up any changes to open flags from > the bdrv_reopen

Re: [Qemu-devel] [PATCH v2] block: mirror - use local_err to avoid NULL errp

2014-02-13 Thread Eric Blake
On 02/13/2014 07:23 AM, Jeff Cody wrote: > When starting a block job, commit_active_start() relies on whether *errp > is set by mirror_start_job. This allows it to determine if the mirror > job start failed, so that it can clean up any changes to open flags from > the bdrv_reopen(). If errp is NU

Re: [Qemu-devel] [PATCH v2] block: mirror - use local_err to avoid NULL errp

2014-02-13 Thread Kevin Wolf
Am 13.02.2014 um 15:23 hat Jeff Cody geschrieben: > When starting a block job, commit_active_start() relies on whether *errp > is set by mirror_start_job. This allows it to determine if the mirror > job start failed, so that it can clean up any changes to open flags from > the bdrv_reopen(). If e

[Qemu-devel] [PATCH v2] block: mirror - use local_err to avoid NULL errp

2014-02-13 Thread Jeff Cody
When starting a block job, commit_active_start() relies on whether *errp is set by mirror_start_job. This allows it to determine if the mirror job start failed, so that it can clean up any changes to open flags from the bdrv_reopen(). If errp is NULL, then it will not be able to determine if mirr