On Thu, Feb 13, 2014 at 09:23:38AM -0500, Jeff Cody wrote: > When starting a block job, commit_active_start() relies on whether *errp > is set by mirror_start_job. This allows it to determine if the mirror > job start failed, so that it can clean up any changes to open flags from > the bdrv_reopen(). If errp is NULL, then it will not be able to > determine if mirror_start_job failed or not. > > To avoid this, use a local Error variable, and then propagate the error > (if any) to errp. > > Reported-by: Markus Armbruster <arm...@redhat.com> > Signed-off-by: Jeff Cody <jc...@redhat.com> > --- > block/mirror.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-)
Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan
