Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-14 Thread Pavel Fedin
Hello! > I wonder how it works for you. Do you aware of an alternative way to > configure the clock > irqflags for more then 24 cores, or is it just ignored. Unfortunately i don't know how it works. > My current status is as follows: > With 64 cores there is no printouts what so ever. > With

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-14 Thread Shlomo Pongratz
Hi Pavel, Please see in-line. Best regards, S.P. From: Pavel Fedin [p.fe...@samsung.com] Sent: Wednesday, May 13, 2015 4:57 PM To: Shlomo Pongratz; qemu-devel@nongnu.org Subject: RE: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500 Hello

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-13 Thread Pavel Fedin
Hello! > 1. In fdt_add_timer why you didn't used the 24 bit limit I posed on the > irqflags? Please note that > the argument is 32 bits wide and 8 bits are for flags. Simply missed it when checking for differences. Please fix. :) Perhaps it is the reason why >=24 CPUs fail for you. > 2. In

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-13 Thread Shlomo Pongratz
> -Original Message- > From: Pavel Fedin [mailto:p.fe...@samsung.com] > Sent: Tuesday, 12 May, 2015 3:33 PM > To: Shlomo Pongratz; qemu-devel@nongnu.org > Subject: RE: [PATCH v2] Add virt-v3 machine that uses GIC-500 > > Hello! > > > BTW did you try going beyond 16 cores I had problems w

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Pavel Fedin
Hello! > BTW did you try going beyond 16 cores I had problems with 32 and 64 cores. Just tried it. Works fine, except qemu takes incredibly long time to start up with so many cores. 64 cores took something like 2 minutes. Indeed, looks like freeze, but if you're patient enough, you'll see it

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Shlomo Pongratz
> -Original Message- > From: Pavel Fedin [mailto:p.fe...@samsung.com] > Sent: Tuesday, 12 May, 2015 12:06 PM > To: Shlomo Pongratz; qemu-devel@nongnu.org > Subject: RE: [PATCH v2] Add virt-v3 machine that uses GIC-500 > > Hello! > > > I just pulled last git and git am-ed your patch on-to

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Daniel P. Berrange
On Tue, May 12, 2015 at 02:15:46PM +0300, Pavel Fedin wrote: > Hello! > > > We are not. Support for GICv2 vs v3 should be dealt with > > by suitable machine properties > > I don't remember whether i clearly wrote about it... First i added a > property, like -machine virt,gicv3=on. But then i de

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Pavel Fedin
Hello! > We are not. Support for GICv2 vs v3 should be dealt with > by suitable machine properties I don't remember whether i clearly wrote about it... First i added a property, like -machine virt,gicv3=on. But then i decided to stick back to different machine name because libvirt does not ha

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 10:20, Daniel P. Berrange wrote: > On Fri, May 08, 2015 at 04:09:01PM +0300, Pavel Fedin wrote: >> static void machvirt_machine_init(void) >> { >> type_register_static(&machvirt_info); >> +type_register_static(&machvirtv3_info); >> } > > If we're going to start adding

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Pavel Fedin
Hello! > If we're going to start adding new machine types for aarch64 with > version numbers, then I think we should we be using a versioning > scheme that matches what we do on x86. ie, define versioned > machine types based on the QEMU release numbers As i wrote in v1 patch message, i am perf

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Daniel P. Berrange
On Fri, May 08, 2015 at 04:09:01PM +0300, Pavel Fedin wrote: > I would like to offer this, slightly improved implementation. The key thing > is a new > kernel_irqchip_type member in Machine class. Currently it it used only by > virt machine for > its internal purposes, however in future it is to

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Pavel Fedin
And one more small note... I have noticed a typo. --- cut --- [VIRT_ITS_CONTROL] = { 0x0802, 0x1000 }, --- cut --- The size should actually be 0x0001. It worked because we don't use ITS. Please fix it for the next merge attempt. Kind regards, Pavel Fedin Expert Engineer Sams

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Pavel Fedin
Hello! > I just pulled last git and git am-ed your patch on-top of my first 3 patches > and got this error: > /home/shlomo/qemu-new.git/qemu-64/hw/arm/virt.c: In function > 'fdt_add_gic_node': > /home/shlomo/qemu-new.git/qemu-64/hw/arm/virt.c:366:17: error: > 'KVM_DEV_TYPE_ARM_VGIC_V3' undeclar

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-11 Thread Shlomo Pongratz
Hi Pavel, Thank you, I just pulled last git and git am-ed your patch on-top of my first 3 patches and got this error: /home/shlomo/qemu-new.git/qemu-64/hw/arm/virt.c: In function ‘fdt_add_gic_node’: /home/shlomo/qemu-new.git/qemu-64/hw/arm/virt.c:366:17: error: ‘KVM_DEV_TYPE_ARM_VGIC_V3’ undec

[Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-08 Thread Pavel Fedin
I would like to offer this, slightly improved implementation. The key thing is a new kernel_irqchip_type member in Machine class. Currently it it used only by virt machine for its internal purposes, however in future it is to be passed to KVM in kvm_irqchip_create(). The variable is defined as i