Re: [Qemu-devel] [PATCH v10 2/5] intc/gic: Extract some reusable vGIC code

2015-08-19 Thread Eric Auger
Hi Pavel, On 08/19/2015 08:36 AM, Pavel Fedin wrote: > Hello! > >> I think it would be worth justifying the changes in signature: >> removal of GICState* due to the introduction of GICV3State and also >> justify replacement of uint32_t *val into void*. > > I described it in the cover letter.

Re: [Qemu-devel] [PATCH v10 2/5] intc/gic: Extract some reusable vGIC code

2015-08-18 Thread Pavel Fedin
Hello! > I think it would be worth justifying the changes in signature: > removal of GICState* due to the introduction of GICV3State and also > justify replacement of uint32_t *val into void*. I described it in the cover letter. Right now you don't see usage for it, but here i started prototy

Re: [Qemu-devel] [PATCH v10 2/5] intc/gic: Extract some reusable vGIC code

2015-08-18 Thread Eric Auger
Hi Pavel, On 08/18/2015 03:33 PM, Pavel Fedin wrote: > These functions are useful also for vGICv3 implementation. Make them > accessible > from within other modules. I think it would be worth justifying the changes in signature: removal of GICState* due to the introduction of GICV3State and also

[Qemu-devel] [PATCH v10 2/5] intc/gic: Extract some reusable vGIC code

2015-08-18 Thread Pavel Fedin
These functions are useful also for vGICv3 implementation. Make them accessible from within other modules. Actually kvm_dist_get() and kvm_dist_put() could also be made reusable, but they would require two extra parameters (s->dev_fd and s->num_cpu) as well as lots of typecasts of 's' to DeviceSta