Hello! > I think it would be worth justifying the changes in signature: > removal of GICState* due to the introduction of GICV3State and also > justify replacement of uint32_t *val into void*.
I described it in the cover letter. Right now you don't see usage for it, but here i started prototyping live migration, and in some cases 'val' is going to be uint64_t. This is because GICD_IROUTER registers are 64 bits wide. kvm_gic_access() by itself does not dereference the pointer, just passes it to the kernel, therefore i decided to make it type-agnostic. > what is the point of moving kvm_gicd_access and kvm_gicc_access here? If > I am not mistaken, they only are used in arm_gic_kvm.c? I think they can > stay static in arm_gic_kvm.c? They will be used in future for live migration, at least kvm_gicd_access. kvm_gicc_access just accompanies it to keep a single style for both. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia
